Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

altered a few access modifiers and removed unused imports #148

Merged
merged 12 commits into from
Jan 25, 2023
Merged

altered a few access modifiers and removed unused imports #148

merged 12 commits into from
Jan 25, 2023

Conversation

Yashita101
Copy link
Contributor

No description provided.

@arunshenoy99
Copy link
Member

arunshenoy99 commented Jan 13, 2023 •
edited
Loading

Note for next time: Let's try and avoid & in branch names because it is a special character that needs to be escaped when working with git, I had to escape the & to checkout this branch - https://docs.github.com/en/get-started/using-git/dealing-with-special-characters-in-branch-and-tag-names#naming-branches-and-tags

arunshenoy99
arunshenoy99 requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great resource to understand PHP Access Modifiers: https://www.w3schools.com/php/php_oop_access_modifiers.asp

includes/Data/Patterns.php Outdated Show resolved Hide resolved
includes/Data/Patterns.php Outdated Show resolved Hide resolved
includes/Data/SiteFeatures.php Show resolved Hide resolved
includes/Data/Themes.php Outdated Show resolved Hide resolved
includes/RestApi/FlowController.php Outdated Show resolved Hide resolved
includes/RestApi/SettingsController.php Outdated Show resolved Hide resolved
includes/RestApi/SitePagesController.php Outdated Show resolved Hide resolved
includes/RestApi/Themes/ThemeGeneratorController.php Outdated Show resolved Hide resolved
includes/TaskManagers/PluginInstallTaskManager.php Outdated Show resolved Hide resolved
@arunshenoy99 arunshenoy99 added the Post Phase 2 Polish Polish PR's for work done in Phase 2 label Jan 13, 2023
arunshenoy99
arunshenoy99 reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed alignment and reviewed, one small thing to take care of, rest all looks good.

includes/RestApi/SettingsController.php Outdated Show resolved Hide resolved
@arunshenoy99 arunshenoy99 merged commit 99e88ac into trunk Jan 25, 2023
@arunshenoy99 arunshenoy99 deleted the Amend-Access-Modifiers-&-code-cleanup branch January 25, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees
No one assigned
Labels
Post Phase 2 Polish Polish PR's for work done in Phase 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yashita101 @arunshenoy99